Build optimized library with CMake #2530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2530
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 0925c2f with merge base 0b12daf ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
3 times, most recently
from
c48f51b to
2cdaebd
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
4 times, most recently
from
0b752e8 to
faff2e1
Compare
GregoryComer
changed the title
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
89f9b71 to
80b113a
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 21, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
80b113a to
9e4f1ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55118200 |
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
9e4f1ef to
e4c33de
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
|
This pull request was exported from Phabricator. Differential Revision: D55118200 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
e4c33de to
5074103
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
5074103 to
bcbc512
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
bcbc512 to
5999a5c
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
5999a5c to
c7b09f5
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
c7b09f5 to
0851b1b
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
0851b1b to
deb9181
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
deb9181 to
31d0662
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
31d0662 to
573a18e
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
573a18e to
5d6df14
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Support optimized kernel library in CMake builds. Note that I'm excluding gelu and log_softmax temporarily, as they require sleef. I will add support in a follow-up to build sleef and enable those two ops. Test Plan: Built executor_runner with optimized_ops_lib and debug logging enabled. Confirmed that optimized kernels were loaded. Ran add example with optimized add kernel. Differential Revision: D55118200 Pulled By: GregoryComer
GregoryComer
force-pushed
the
cmake-optimized-lib
branch
from
5d6df14 to
0925c2f
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@GregoryComer merged this pull request in 911e9a3. |
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Overriding pre-existing CI failures in llama runner and mac unit test. bypass-github-export-checks bypass-github-executorch-ci-checks X-link: pytorch/executorch#2530 Reviewed By: kimishpatel Differential Revision: D55118200 Pulled By: GregoryComer fbshipit-source-id: b094980e9fc402e316a4d7cfb24ee3646a00d64e
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Mar 22, 2024
Summary: Support optimized kernel library in CMake builds. Overriding pre-existing CI failures in llama runner and mac unit test. bypass-github-export-checks bypass-github-executorch-ci-checks X-link: pytorch/executorch#2530 Reviewed By: kimishpatel Differential Revision: D55118200 Pulled By: GregoryComer fbshipit-source-id: b094980e9fc402e316a4d7cfb24ee3646a00d64e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support optimized kernel library in CMake builds.