remove duplicate deepcopy #2550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2550
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6cd9c3b with merge base 12b5324 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55133796 |
cccclai
approved these changes
Mar 21, 2024
lucylq
force-pushed
the
export-D55133796
branch
from
527302e to
d07fb5e
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Mar 21, 2024
Summary: Program is deep copied inside backend_api before being passed to preprocess: https://www.internalfb.com/code/fbsource/fbcode/executorch/exir/backend/backend_api.py?lines=106 And then deepcopied again here. Reviewed By: cccclai Differential Revision: D55133796
|
This pull request was exported from Phabricator. Differential Revision: D55133796 |
Summary: Program is deep copied inside backend_api before being passed to preprocess: https://www.internalfb.com/code/fbsource/fbcode/executorch/exir/backend/backend_api.py?lines=106 And then deepcopied again here. Reviewed By: cccclai Differential Revision: D55133796
lucylq
force-pushed
the
export-D55133796
branch
from
d07fb5e to
6cd9c3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55133796 |
|
This pull request has been merged in cd9a84c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Program is deep copied inside backend_api before being passed to preprocess:
https://www.internalfb.com/code/fbsource/fbcode/executorch/exir/backend/backend_api.py?lines=106
And then deepcopied again here.
Differential Revision: D55133796