Fix lift_constant_tensor_pass to make sure constants are not inserted in the state dict #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2558
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 10d61f0 with merge base 95b0daa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
887613c to
91a801b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
91a801b to
c9c227a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Differential Revision: D55175415
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
c9c227a to
557b9dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
tarun292
force-pushed
the
export-D55175415
branch
from
557b9dc to
62f0c62
Compare
tarun292
added a commit
that referenced
this pull request
Mar 25, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Differential Revision: D55175415
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
62f0c62 to
c2692e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
tarun292
added a commit
that referenced
this pull request
Mar 25, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
tarun292
force-pushed
the
export-D55175415
branch
from
c2692e9 to
7434384
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
angelayi
approved these changes
Mar 25, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
7434384 to
cf60df0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
tarun292
added a commit
that referenced
this pull request
Mar 28, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
tarun292
force-pushed
the
export-D55175415
branch
from
cf60df0 to
02d6796
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
facebook-github-bot
force-pushed
the
export-D55175415
branch
from
02d6796 to
4b1b6aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
… in the state dict (#2558) Summary: Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415
tarun292
force-pushed
the
export-D55175415
branch
from
4b1b6aa to
10d61f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55175415 |
|
This pull request has been merged in a624345. |
|
This pull request has been reverted by dc909be. |
dbort
pushed a commit
to dbort/executorch
that referenced
this pull request
Mar 30, 2024
… in the state dict (pytorch#2558) Summary: Pull Request resolved: pytorch#2558 Currently in `lift_tensor_constant_pass` the lifted constants are being placed in the state dict which is the wrong place for them. They should be inserted in the `constants` section of the `ExportedProgram` which this diff addresses. Reviewed By: angelayi Differential Revision: D55175415 fbshipit-source-id: afe7f4df94f89de6d0c43dab824c498567a6b21f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D55175415