Skip to content

Add debug feature to deserialize TOSA fb on dump_artifact #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

freddan80
Copy link
Collaborator

The deserialized, human readable, TOSA fb is appended to the GraphModule print that is output with dump_artifact() on the Partition stage. Also, bump the TOSA serialization lib SHA, to avoid verbose warning messages.

The deserialized, human readable, TOSA fb is appended to the
GraphModule print that is output with dump_artifact() on the
Partition stage. Also, bump the TOSA serialization lib SHA,
to avoid verbose warning messages.

Change-Id: Ibb3120993d75293824f2ccb5a1b3981db64a2354
Signed-off-by: Fredrik Knutsson <[email protected]>
Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2560

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ac8ea41 with merge base 12b5324 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-coreml-delegate / macos-job (gh)
    /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm:387:43: error: no member named 'ModelPackage' in '(anonymous namespace)::ModelAssetType'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2024
@freddan80 freddan80 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 21, 2024
@freddan80 freddan80 requested a review from digantdesai March 21, 2024 10:25
from pprint import pformat

to_print = None
for spec in self.graph_module.lowered_module_0.compile_specs:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an API to or other 'nicer' way to access

graph_module.lowered_module_0.compile_specs

and

graph_module.lowered_module_0.processed_bytes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of, cc @cccclai

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. For ArmTester do you want to move Quantize stage to use ArmQuantizer now that it is ready?

from pprint import pformat

to_print = None
for spec in self.graph_module.lowered_module_0.compile_specs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of, cc @cccclai

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 9c7bb45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants