New util function to print delegation summary #2611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2611
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 07ddbb6 with merge base 08b644f ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 23, 2024
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Differential Revision: D55239751
Olivia-liu
force-pushed
the
export-D55239751
branch
from
93a7f24 to
0290008
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
Olivia-liu
force-pushed
the
export-D55239751
branch
from
0290008 to
5e2d830
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 25, 2024
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Differential Revision: D55239751
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
Olivia-liu
force-pushed
the
export-D55239751
branch
from
5e2d830 to
5f906b2
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 25, 2024
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Differential Revision: D55239751
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 26, 2024
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Differential Revision: D55239751
Olivia-liu
force-pushed
the
export-D55239751
branch
from
5f906b2 to
dd055b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
dbort
approved these changes
Mar 26, 2024
Olivia-liu
force-pushed
the
export-D55239751
branch
from
dd055b1 to
c81c6e3
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 26, 2024
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Reviewed By: dbort Differential Revision: D55239751
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
Summary: Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Reviewed By: dbort Differential Revision: D55239751
Olivia-liu
force-pushed
the
export-D55239751
branch
from
c81c6e3 to
07ddbb6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55239751 |
|
This pull request has been merged in a19a32b. |
|
@pytorchbot cherry-pick --onto release/0.2 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Summary: bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Pull Request resolved: #2611 Because what happened to the graph in to_backend() is pretty opaque to the users, the existing [print_delegated_graph()](https://fburl.com/code/4xa5oewv) is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph. Original design doc: https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing **Note:** The added `import pandas` shouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2 Reviewed By: dbort Differential Revision: D55239751 fbshipit-source-id: 81000953b51d87f6d509a6589685fe677a8eec5b (cherry picked from commit a19a32b)
Cherry picking #2611The cherry pick PR is at #2726 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Because what happened to the graph in to_backend() is pretty opaque to the users, the existing print_delegated_graph() is good but might be too much for new users, so implemented this new util function to give a more lightweight summary for the delegated graph.
Original design doc:
https://docs.google.com/document/d/19ZSDddm23MnGvFUrkV9clwHwLvXzAo2IZtbkr9VChjE/edit?usp=sharing
Note: The added
import pandasshouldn't be an issue because we already have pandas in the install requirement is executorch oss: https://fburl.com/code/p55654r2Differential Revision: D55239751