Skip to content

[xnnpack_backend][cmake] fix xnn executor runner cmake #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Mar 23, 2024

the xnnpack backend's cmake refactor lost the portable_ops_lib for xnn_executor_runner so adding it back in this diff

Copy link

pytorch-bot bot commented Mar 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2613

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 4 Unrelated Failures

As of commit b69df09 with merge base 126f918 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2024
@facebook-github-bot
Copy link
Contributor

@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mcr229 mcr229 requested a review from guangy10 March 23, 2024 18:03
@facebook-github-bot
Copy link
Contributor

@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to enable trunk flow becasue we want to know if it actually resolve the macos jobs. I think if this PR fixes the issue, we would be able to see the dup resignation issue then

@mcr229
Copy link
Contributor Author

mcr229 commented Mar 23, 2024

Need to enable trunk flow becasue we want to know if it actually resolve the macos jobs. I think if this PR fixes the issue, we would be able to see the dup resignation issue then

seems like my changes are ontop of some older diffs which got reverted, let me rebase and resubmit

@mcr229 mcr229 force-pushed the fix-xnn-executor-runner branch from 4e48b5e to cf6e568 Compare March 23, 2024 18:36
@mcr229 mcr229 changed the base branch from main to gh/larryliu0820/15/base March 23, 2024 18:36
@mcr229 mcr229 changed the base branch from gh/larryliu0820/15/base to main March 23, 2024 18:36
@mcr229 mcr229 changed the base branch from main to stable March 23, 2024 18:37
@mcr229 mcr229 changed the base branch from stable to main March 23, 2024 18:38
@mcr229 mcr229 force-pushed the fix-xnn-executor-runner branch from cf6e568 to b69df09 Compare March 23, 2024 18:40
@facebook-github-bot
Copy link
Contributor

@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mcr229 merged this pull request in 8be87e2.

@mcr229 mcr229 deleted the fix-xnn-executor-runner branch March 24, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants