Add pooling and softmax unittests for Arm backend #2645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oscarandersson8218
commented
Mar 25, 2024
oscarandersson8218
commented
- Add SoftMax unittests
- Add mean_dim unittests
- Add AvgPool2d unittests
- Enable linear u55 test
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2645
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fc4decd with merge base 853fb5b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Mar 25, 2024
backends/arm/test/test_models.py
Outdated
| return self.softmax(x) | ||
|
|
||
| @register_test | ||
| # @register_test |
There was a problem hiding this comment.
No, pushed a new patch reverting that change.
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Rebase please? |
* Add SoftMax unittests * Add mean_dim unittests * Add AvgPool2d unittests * Enable linear u55 test Change-Id: I0a1f9f1b0f1fea13a2c9727b6b57f09fff8da5eb Signed-off-by: Oscar Andersson <[email protected]>
Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I81b431f9de2b151d61bf93916370ff4d948bcd97
oscarandersson8218
force-pushed
the
pooling_tests
branch
from
3ba37ad to
fc4decd
Compare
mergennachin
approved these changes
Mar 27, 2024
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 65f3e18. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 4, 2024
Summary: * Add SoftMax unittests * Add mean_dim unittests * Add AvgPool2d unittests * Enable linear u55 test Pull Request resolved: pytorch#2645 Reviewed By: mergennachin Differential Revision: D55316136 Pulled By: digantdesai fbshipit-source-id: 80d9a2e34a786742b47cb08b9b9c640f6b61964d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.