Skip to content

Port Arm backend op unittests: conv op + other ops #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Port Arm backend op unittests: conv op + other ops #2647

wants to merge 5 commits into from

Conversation

freddan80
Copy link
Collaborator

Ported unit tests with combined ops.

  • Removed random seeds
  • Removed corresponing legacy test cases

@freddan80
Port Arm op unittests: conv op + other ops
b705860 
Signed-off-by: Fredrik Knutsson <[email protected]>
Change-Id: I0a2f83ff9eb245ebc6dc7714d8a3080eaf394a8e
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2647

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 139cebc with merge base bd6ceab (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2024
@freddan80 freddan80 requested a review from digantdesai March 25, 2024 10:31
@freddan80 freddan80 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 25, 2024
digantdesai
digantdesai approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@freddan80
Copy link
Collaborator Author

CI failure is related to this PR. We've move around the logger and I missed to update it. Will push fix tomorrow.

@freddan80
Adressing CI failures
5620410 
Change-Id: I7acb72e31ff005d614fba761b4c80ce8646b4646
@freddan80
Copy link
Collaborator Author

These CI failures are unrelated to the PR

@digantdesai
Copy link
Contributor

Rebase please?

@mergennachin mergennachin self-requested a review March 27, 2024 23:39
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Please rebase on top of the other one? executorch/backends/arm/test/test_models.py might have a conflict.

@freddan80
Copy link
Collaborator Author

Will do

freddan80 added 2 commits April 3, 2024 09:25
@freddan80
Merge remote-tracking branch 'origin/main' into pr_conv_combos
b132700 
Change-Id: Icc219071e99fbb86848d3f871feb12c67535f93c
@freddan80
Fix rebase issue
139cebc 
Change-Id: I2b18d99b3df7832ce500b213177ab3c5cf9308c7
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in be618c2.

kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request Apr 4, 2024
@freddan80 @kirklandsign
Port Arm backend op unittests: conv op + other ops (pytorch#2647)
a9fee39 
Summary:
Ported unit tests with combined ops.

* Removed random seeds
* Removed corresponing legacy test cases

Pull Request resolved: pytorch#2647

Reviewed By: mergennachin

Differential Revision: D55316080

Pulled By: digantdesai

fbshipit-source-id: 5da3946fb191f47b0669c2157518bc93bd0c7554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@mergennachin mergennachin mergennachin approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freddan80 @facebook-github-bot @digantdesai @mergennachin