off by one error in sdpa cache op #2689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: start_pos is where we currently are. so when start_pos = 127 we are currently generating the 128th token Reviewed By: kimishpatel Differential Revision: D55370500
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2689
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b4eb78e with merge base 61b1b83 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55370500 |
|
This pull request has been merged in 5e23c33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: start_pos is where we currently are. so when start_pos = 127 we are currently generating the 128th token
Reviewed By: kimishpatel
Differential Revision: D55370500