Simplify pip install step of install_requirements.sh #2731
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2731
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c4f93f8 with merge base f7fbc7a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
force-pushed
the
min-install
branch
2 times, most recently
from
57c878e to
4bf524a
Compare
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: It's not clear why we were using --force-reinstall; if the requested versions are different from what's currently installed, pip will handle the reinstallation. And calling pip multiple times with --force-reinstall meant that we were uninstalling and reinstalling the same packages over and over. Now we only call `pip install` once for requirements, and we do not force reinstall. On my machine, without enabling pybindings, a no-op run of this script (i.e. when all packages are up-to-date) takes 7 seconds, including the `pip install .`. Test Plan: ``` ./install_requirements.sh ``` Reviewers: Subscribers: Tasks: Tags:
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
It's not clear why we were using --force-reinstall; if the requested versions are different from what's currently installed, pip will handle the reinstallation.
And calling pip multiple times with --force-reinstall meant that we were uninstalling and reinstalling the same packages over and over.
Now we only call
pip installonce for requirements, and we do not force reinstall. On my machine, without enabling pybindings, a no-op run of this script (i.e. when all packages are up-to-date) takes 7 seconds, including thepip install ..Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: