add runner android build ci #2733
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2733
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2a24105 with merge base 694d841 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
.ci/scripts/build_llama_android.sh
Outdated
| ANDROID_NDK=/opt/ndk | ||
| BUCK2=$(which buck2) | ||
| FLATC=$(which flatc) ANDROID_ABI=arm64-v8a | ||
| cmake -DBUCK2="$BUCK" -DCMAKE_TOOLCHAIN_FILE="$ANDROID_NDK"/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=android-23 -DCMAKE_INSTALL_PREFIX=cmake-android-out -DCMAKE_BUILD_TYPE=Release -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON -DEXECUTORCH_ENABLE_LOGGING=1 -DEXECUTORCH_BUILD_XNNPACK=ON -DPYTHON_EXECUTABLE=python -DEXECUTORCH_BUILD_OPTIMIZED=ON -DXNNPACK_ENABLE_ARM_BF16=OFF -Bcmake-android-out . |
There was a problem hiding this comment.
nit format one option per line? Just too hard to read / parse - something like this
| cmake -DBUCK2="$BUCK" -DCMAKE_TOOLCHAIN_FILE="$ANDROID_NDK"/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DANDROID_PLATFORM=android-23 -DCMAKE_INSTALL_PREFIX=cmake-android-out -DCMAKE_BUILD_TYPE=Release -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON -DEXECUTORCH_ENABLE_LOGGING=1 -DEXECUTORCH_BUILD_XNNPACK=ON -DPYTHON_EXECUTABLE=python -DEXECUTORCH_BUILD_OPTIMIZED=ON -DXNNPACK_ENABLE_ARM_BF16=OFF -Bcmake-android-out . | |
| cmake \ | |
| -DBUCK2="$BUCK" \ | |
| -DCMAKE_TOOLCHAIN_FILE="$ANDROID_NDK"/build/cmake/android.toolchain.cmake \ | |
| -DANDROID_ABI=arm64-v8a \ | |
| -DANDROID_PLATFORM=android-23 \ | |
| -DCMAKE_INSTALL_PREFIX=cmake-android-out \ | |
| -DCMAKE_BUILD_TYPE=Release \ | |
| -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \ | |
| -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \ | |
| -DEXECUTORCH_ENABLE_LOGGING=1 \ | |
| -DEXECUTORCH_BUILD_XNNPACK=ON \ | |
| -DPYTHON_EXECUTABLE=python \ | |
| -DEXECUTORCH_BUILD_OPTIMIZED=ON \ | |
| -DXNNPACK_ENABLE_ARM_BF16=OFF \ | |
| -Bcmake-android-out . |
There was a problem hiding this comment.
why do we have to disable BF16? Which version of the NDK we have for the CI job?
There was a problem hiding this comment.
r26c, I ran into error with DXNNPACK_ENABLE_ARM_BF16=OFF, maybe can try removing it later
There was a problem hiding this comment.
yeah, I didnt have to do this. I would suggest try removing it
.ci/scripts/build_llama_android.sh
Outdated
| } | ||
|
|
||
| build_llama_runner() { | ||
| echo "Exporting MobilenetV2" |
There was a problem hiding this comment.
- Running MV2? :p
- Update BUCK2 path
- why hardcode
-j16?
There was a problem hiding this comment.
was just copying my local command...will updated
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: As title, add a new CI to cover cross compile android build for llama runner Pull Request resolved: pytorch#2733 Reviewed By: kimishpatel Differential Revision: D55512563 Pulled By: cccclai fbshipit-source-id: a9089abc2acfac4f61750933a86facae639f1b8e
As title, add a new CI to cover cross compile android build for llama runner