Plumb group_size to 4b quant #2734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2734
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9dc2a9a with merge base 694d841 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55458352 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Differential Revision: D55458352
mergennachin
approved these changes
Mar 28, 2024
Jack-Khuu
force-pushed
the
export-D55458352
branch
from
2dd63de to
22d70ab
Compare
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
|
This pull request was exported from Phabricator. Differential Revision: D55458352 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
force-pushed
the
export-D55458352
branch
from
22d70ab to
643562f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55458352 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Pull Request resolved: pytorch#2734 Previously group size wasn't being passed properly to 4b quant. This just passes it through Differential Revision: https://internalfb.com/D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Pull Request resolved: pytorch#2734 Previously group size wasn't being passed properly to 4b quant. This just passes it through Differential Revision: https://internalfb.com/D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Pull Request resolved: pytorch#2734 Previously group size wasn't being passed properly to 4b quant. This just passes it through Differential Revision: https://internalfb.com/D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
force-pushed
the
export-D55458352
branch
from
643562f to
1cfad69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55458352 |
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
force-pushed
the
export-D55458352
branch
from
1cfad69 to
9dc2a9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55458352 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352
|
This pull request has been merged in 4df99cc. |
dbort
pushed a commit
to dbort/executorch
that referenced
this pull request
Mar 30, 2024
Summary: Pull Request resolved: pytorch#2734 Previously group size wasn't being passed properly to 4b quant. This just passes it through Reviewed By: mergennachin Differential Revision: D55458352 fbshipit-source-id: d3c9f1c3d418ce0b5b4900c01800bdea81dddcd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously group size wasn't being passed properly to 4b quant. This just passes it through
Differential Revision: D55458352