fix bug in mask slicing for 1 length sequence and no kvcache #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2742
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5fe2784 with merge base 45c2557 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55465010 |
mergennachin
approved these changes
Mar 28, 2024
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
JacobSzwejbka
force-pushed
the
export-D55465010
branch
from
9f95512 to
5fe2784
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55465010 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
…#2742) Summary: No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010
|
This pull request has been merged in 501b5a2. |
dbort
pushed a commit
to dbort/executorch
that referenced
this pull request
Mar 30, 2024
…#2742) Summary: Pull Request resolved: pytorch#2742 No reason to squeeze anymore since the mask is always 2d Reviewed By: mergennachin Differential Revision: D55465010 fbshipit-source-id: d9832eb2a6a4ea275dc8dd5ed681b6d25eefd6df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: No reason to squeeze anymore since the mask is always 2d
Differential Revision: D55465010