Ease main thread by updating UI on every Nth token only. #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2760
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 85b11c2 with merge base f0c6666 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55532081 |
|
This pull request was exported from Phabricator. Differential Revision: D55532081 |
Summary: . Reviewed By: kirklandsign Differential Revision: D55532081
|
This pull request was exported from Phabricator. Differential Revision: D55532081 |
|
This pull request has been merged in 764c353. |
dbort
pushed a commit
to dbort/executorch
that referenced
this pull request
Mar 30, 2024
Summary: Pull Request resolved: pytorch#2760 bypass-github-export-checks Reviewed By: kirklandsign Differential Revision: D55532081 fbshipit-source-id: 48c67c2872a52c407a0856af566733b079bca99f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: .
Differential Revision: D55532081