Skip to content

Adding EXECUTORCH_CLIENTS visibility to parallel extension #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ChristianWLang
Copy link
Contributor

@ChristianWLang ChristianWLang commented Mar 29, 2024

Summary: title.

Differential Revision: D55505037

@bypass-github-pytorch-ci-checks

Copy link

pytorch-bot bot commented Mar 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2768

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ded95eb with merge base daa217f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

@ChristianWLang ChristianWLang changed the title Migrating to executorch Adding EXECUTORCH_CLIENTS visibility to parallel extension Mar 29, 2024
ChristianWLang added a commit to ChristianWLang/executorch that referenced this pull request Mar 29, 2024
Summary:

Migrating to ET from lite.

Differential Revision: D55505037
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

ChristianWLang added a commit to ChristianWLang/executorch that referenced this pull request Apr 1, 2024
Summary:

Migrating to ET from lite.

Differential Revision: D55505037
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

@mergennachin mergennachin self-requested a review April 1, 2024 15:33
@facebook-github-bot
Copy link
Contributor

@ChristianWLang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ChristianWLang added a commit to ChristianWLang/executorch that referenced this pull request Apr 1, 2024
)

Summary:
title.


Reviewed By: mergennachin

Differential Revision: D55505037

Pulled By: ChristianWLang
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

ChristianWLang added a commit to ChristianWLang/executorch that referenced this pull request Apr 1, 2024
Summary:
title.


Reviewed By: mergennachin

Differential Revision: D55505037

Pulled By: ChristianWLang
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

Summary:
title.


Test Plan:
```
[[email protected] /data/sandcastle/boxes/fbsource (82a3fe9ca)]$ buck2 test //xplat/cria/core:cria
Watchman fresh instance: new mergebase, cleared graph state, cleared dep files
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Soft Error: source_file_missing: Source file `Launder.h` does not exist as a member of package `fbsource//xplat/folly/lang`.
Buck UI: https://www.internalfb.com/buck2/24c6e2bb-c070-4a31-a12e-e3b4821df7dd
Test UI: https://www.internalfb.com/intern/testinfra/testrun/10133099189773521
Network: Up: 763KiB  Down: 508MiB  (reSessionID-13d45184-0acc-48ee-96e7-1979b53d74a7)
Jobs completed: 4460. Time elapsed: 41.9s.
Cache hits: 96%. Commands: 1015 (cached: 973, remote: 0, local: 42)
Tests finished: Pass 9. Fail 0. Fatal 0. Skip 0. Build failure 0
```

Reviewed By: mergennachin

Differential Revision: D55505037

Pulled By: ChristianWLang
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55505037

@facebook-github-bot
Copy link
Contributor

@ChristianWLang merged this pull request in d612c23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants