Skip to content

Allow each model to choose its own runner #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .ci/scripts/gather_test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
"buck2",
"cmake",
]
DEFAULT_RUNNER = "linux.2xlarge"
RUNNERS = {
# This one runs OOM on smaller runner, the root cause is unclear (T163016365)
"w2l": "linux.12xlarge"
}


def set_output(name: str, val: Any) -> None:
Expand Down Expand Up @@ -53,6 +58,7 @@ def export_models_for_ci() -> None:
"model": name,
"quantization": quantization,
"xnnpack_delegation": xnnpack_delegation,
"runner": RUNNERS.get(name, DEFAULT_RUNNER),
}
)
set_output("models", json.dumps(models))
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
matrix: ${{ fromJSON(needs.gather-models.outputs.models) }}
fail-fast: false
with:
runner: linux.2xlarge
runner: ${{ matrix.runner }}
docker-image: executorch-ubuntu-22.04-clang12
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
- build-tool: cmake
fail-fast: false
with:
runner: linux.2xlarge
runner: ${{ matrix.runner }}
docker-image: executorch-ubuntu-22.04-clang12
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
- build-tool: cmake
fail-fast: false
with:
runner: linux.2xlarge
runner: ${{ matrix.runner }}
docker-image: executorch-ubuntu-22.04-clang12
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
Expand Down