Skip to content

[CoreML Backend] Propagate debug handle. #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CoreML Backend] Propagate debug handle. #2783

wants to merge 1 commit into from

Conversation

cymbalrush
Copy link
Contributor

Propagate debug handles so that the runtime could log profiling events with the correct handle.

Screenshot 2024-03-31 at 11 05 22 AM

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2783

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0d5e887 with merge base e283967 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2024
@cymbalrush
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cymbalrush cymbalrush force-pushed the coreml_delegate_hanlde_mapping branch from 1ad0733 to 0d5e887 Compare March 31, 2024 18:33
@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@shoumikhin merged this pull request in 091e524.

cccclai
cccclai reviewed Apr 1, 2024
View reviewed changes
backends/apple/coreml/compiler/coreml_preprocess.py
def preprocess_model(
mlmodel: ct.models.MLModel, model_type: MODEL_TYPE
) -> PreprocessResult:
identifier = str(uuid.uuid4())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, we also provide the helper function to build the identifier, if you find it helpful. It's totally fine to use your own way, and maybe we can learn the reason. cc: @tarun292 @Jack-Khuu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai left review comments

@shoumikhin shoumikhin shoumikhin approved these changes

@Olivia-liu Olivia-liu Awaiting requested review from Olivia-liu

@tarun292 tarun292 Awaiting requested review from tarun292

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cymbalrush @facebook-github-bot @shoumikhin @cccclai