Force callers to manually provide GPTQ args #2795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2795
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b7a6f62 with merge base d612c23 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55605859 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Default values for quant are convenient, but have caused confusion. Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified: * Group Size * Calibration Limit * Calibration Sequence Length --- Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers Differential Revision: D55605859
Jack-Khuu
force-pushed
the
export-D55605859
branch
from
2ce4b40 to
8a5f093
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55605859 |
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Default values for quant are convenient, but have caused confusion. Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified: * Group Size * Calibration Limit * Calibration Sequence Length --- Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers Differential Revision: D55605859
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Default values for quant are convenient, but have caused confusion. Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified: * Group Size * Calibration Limit * Calibration Sequence Length --- Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers Differential Revision: D55605859
mergennachin
approved these changes
Apr 2, 2024
Jack-Khuu
force-pushed
the
export-D55605859
branch
from
8a5f093 to
d13164c
Compare
Jack-Khuu
added a commit
to Jack-Khuu/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Default values for quant are convenient, but have caused confusion. Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified: * Group Size * Calibration Limit * Calibration Sequence Length --- Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers Reviewed By: mergennachin Differential Revision: D55605859
|
This pull request was exported from Phabricator. Differential Revision: D55605859 |
Summary: Default values for quant are convenient, but have caused confusion. Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified: * Group Size * Calibration Limit * Calibration Sequence Length --- Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers Reviewed By: mergennachin Differential Revision: D55605859
Jack-Khuu
force-pushed
the
export-D55605859
branch
from
d13164c to
b7a6f62
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55605859 |
|
This pull request has been merged in 31d5c61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Default values for quant are convenient, but have caused confusion.
Since there are no active users of GPTQ, we want to pre-empt potential ambiguity by making the following fields required and manually specified:
Note: Group Size's default value is untouched since it is utilized by int4 quant and has active callers
Differential Revision: D55605859