Update namespace from at::native::vulkan to vkcompute #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2798
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc73eb4 with merge base 6965120 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
facebook-github-bot
added
the
CLA Signed
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
jorgep31415
approved these changes
Apr 1, 2024
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. bypass-github-export-checks Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. bypass-github-export-checks Reviewed By: jorgep31415 Differential Revision: D55608083
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. bypass-github-export-checks Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
Differential Revision: D55607115
Summary: Pull Request resolved: pytorch#2798 ## Context The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the `at::native::vulkan` namespace is deprecated in favor of `vkcompute`. bypass-github-export-checks Reviewed By: jorgep31415 Differential Revision: D55608083
|
This pull request was exported from Phabricator. Differential Revision: D55608083 |
|
This pull request has been merged in c06c89f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
The previous change in the stack forks the Vulkan Compute API into the ExecuTorch directory. Now that there is no longer any dependency on ATen-Vulkan, the
at::native::vulkannamespace is deprecated in favor ofvkcompute.Differential Revision: D55608083