Add schema changes for delegate profiling in etdump_flatcc #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
vmpuri
force-pushed
the
export-D49076428
branch
from
95e8e18 to
f236b88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
vmpuri
force-pushed
the
export-D49076428
branch
from
f236b88 to
76d9de3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
vmpuri
force-pushed
the
export-D49076428
branch
from
76d9de3 to
bcf387f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
Summary: Make a few changes to the flatbuffer+python schema to enable delegate profiling - Remove `EventType` - we can determine the event type by simply checking which of the fields in Event is null. - Add `instruction_id`, `delegate_debug_id_int` and `delegate_debug_id_str` to `ProfileEvent` to replace `debug_handle` Reviewed By: Jack-Khuu Differential Revision: D49076428
vmpuri
force-pushed
the
export-D49076428
branch
from
bcf387f to
50dc139
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
vmpuri
force-pushed
the
export-D49076428
branch
from
50dc139 to
6e186c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49076428 |
|
This pull request has been merged in 8c0dcea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make a few changes to the flatbuffer+python schema to enable delegate profiling
EventType- we can determine the event type by simply checking which of the fields in Event is null.instruction_id,delegate_debug_id_intanddelegate_debug_id_strtoProfileEventto replacedebug_handleDifferential Revision: D49076428