Android app use stats from runner #2801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2801
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5a9dca1 with merge base f64130e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
force-pushed
the
android-app-update-stats
branch
from
207846b to
cb22e75
Compare
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 4, 2024
Summary: Instead of calculating from the app, we use number reported by runner so it's the same as binary. Right now we only report generated t/s from binary. TODO: Create a Java class for other stats so that Java layer can get it through JNI. Differential Revision: D55776409 Pulled By: kirklandsign
kirklandsign
force-pushed
the
android-app-update-stats
branch
from
cb22e75 to
ec101e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55776409 |
Summary: Instead of calculating from the app, we use number reported by runner so it's the same as binary. Right now we only report generated t/s from binary. TODO: Create a Java class for other stats so that Java layer can get it through JNI. Reviewed By: shoumikhin Differential Revision: D55776409 Pulled By: kirklandsign
kirklandsign
force-pushed
the
android-app-update-stats
branch
from
ec101e5 to
5a9dca1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55776409 |
shoumikhin
approved these changes
Apr 5, 2024
|
@kirklandsign merged this pull request in 8d8fe09. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calculating from the app, we use number reported by runner so it's the same as binary.
Right now we only report generated t/s from binary.
TODO: Create a Java class for other stats so that Java layer can get it through JNI.