[ET-VK][CMake] Build with forked API instead of depending on PyTorch #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2813
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c079d3 with merge base 7938344 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
copyrightly
approved these changes
Apr 2, 2024
jorgep31415
approved these changes
Apr 2, 2024
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: pytorch#2813 ## Context pytorch#2797 forked the required components from PyTorch-Vulkan into the ExecuTorch directory, which means that building the ExecuTorch Vulkan delegate no longer needs to depend on PyTorch. This is a simple change to the Vulkan delegate CMakeLists.txt to build using the forked Vulkan API instead of the Vulkan API contained in `pytorch` submodule. imported-using-ghimport Test Plan: Imported from OSS Reviewed By: jorgep31415 Differential Revision: D55660791 Pulled By: SS-JIA fbshipit-source-id: 3c4b018de1092028d02a7d269d62749a38f98a83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
#2797 forked the required components from PyTorch-Vulkan into the ExecuTorch directory, which means that building the ExecuTorch Vulkan delegate no longer needs to depend on PyTorch.
This is a simple change to the Vulkan delegate CMakeLists.txt to build using the forked Vulkan API instead of the Vulkan API contained in
pytorchsubmodule.Differential Revision: D55660791