Skip to content

fix coreml partitioner for llama #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Apr 2, 2024

Differential Revision: D55663281

Copy link

pytorch-bot bot commented Apr 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2816

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3477af8 with merge base 399482c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary: Pull Request resolved: pytorch#2816

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from e802715 to 6a326a2 Compare April 3, 2024 04:32
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 6a326a2 to 4d4f37b Compare April 3, 2024 05:46
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 4d4f37b to efa73a0 Compare April 3, 2024 05:53
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from efa73a0 to 0fc3746 Compare April 3, 2024 18:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 0fc3746 to cac07d4 Compare April 3, 2024 18:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 3, 2024
Summary:


Fix the constant nodes tagging for coreml partitioner
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from cac07d4 to 73192aa Compare April 3, 2024 18:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

@cccclai cccclai force-pushed the export-D55663281 branch from 73192aa to 540d9df Compare April 4, 2024 00:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 4, 2024
Summary:


Fix the constant nodes tagging util function
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Differential Revision: D55663281
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change!

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 4, 2024
Summary:


Fix the constant nodes tagging util function
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Reviewed By: mcr229

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 540d9df to 6f9ea64 Compare April 4, 2024 06:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 4, 2024
Summary:


Fix the constant nodes tagging util function
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Reviewed By: mcr229

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 6f9ea64 to a53fa3a Compare April 4, 2024 06:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 4, 2024
Summary:


Fix the constant nodes tagging util function
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Reviewed By: mcr229

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from a53fa3a to 69ab9fe Compare April 4, 2024 06:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

Summary:


Fix the constant nodes tagging util function
```
python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache
```

Reviewed By: mcr229

Differential Revision: D55663281
@cccclai cccclai force-pushed the export-D55663281 branch from 69ab9fe to 3477af8 Compare April 4, 2024 06:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55663281

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 64a6757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants