Skip one op for coreml partitioner #2826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2826
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a7047b2 with merge base 88b6cd2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
cccclai
changed the title
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680297
cccclai
force-pushed
the
export-D55680297
branch
from
6cbe1f5 to
f1ef94b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
cccclai
force-pushed
the
export-D55680297
branch
from
f1ef94b to
9329a75
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680297
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 4, 2024
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680297
cccclai
force-pushed
the
export-D55680297
branch
from
9329a75 to
88df6cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 4, 2024
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680297
cccclai
force-pushed
the
export-D55680297
branch
from
88df6cd to
f18cb99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
mergennachin
approved these changes
Apr 4, 2024
cccclai
changed the title
|
Thanks Yifan for adding the index with bool, so we can skip one less op! |
cccclai
force-pushed
the
export-D55680297
branch
from
f18cb99 to
549001c
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 4, 2024
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: mergennachin Differential Revision: D55680297
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
Summary: There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now ``` "aten.index.tensor", "aten.index_put.default" ``` test with ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: mergennachin Differential Revision: D55680297
cccclai
force-pushed
the
export-D55680297
branch
from
549001c to
a7047b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680297 |
|
This pull request has been merged in dd06b7a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are some issues with the current two ops in coreml side. While waiting for the fix, skip them for now
test with
also test the stories-llama model
Differential Revision: D55680297