fix a set union bug #2827
Closed
fix a set union bug #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2827
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1f15d1e with merge base be618c2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55680296 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680296
cccclai
force-pushed
the
export-D55680296
branch
from
495cfd0 to
d4e6ccd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680296 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680296
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Differential Revision: D55680296
angelayi
approved these changes
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296
cccclai
force-pushed
the
export-D55680296
branch
from
d4e6ccd to
1f15d1e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55680296 |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 3, 2024
Summary: It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296
|
This pull request has been merged in a25dea6. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: pytorch#2827 It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code ``` python3 -m examples.models.llama2.export_llama --coreml --use_kv_cache ``` Reviewed By: angelayi Differential Revision: D55680296 fbshipit-source-id: 906d508a276a91bd4b1caa295ce547e9686612ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's a bug, we need to keep union the original set with the new set from the for loop, however the original code just overwrite the original set. Test with coreml + llama code
Differential Revision: D55680296