[Executorch][llama] Make pthreadpool not use GCD on apple platforms #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My local M1 runs reveal that GCG was not great as a threadpool Differential Revision: [D55712512](https://our.internmc.facebook.com/intern/diff/D55712512/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2839
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 05d3ac4 with merge base be618c2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55712512 |
kimishpatel
added a commit
that referenced
this pull request
Apr 3, 2024
My local M1 runs reveal that GCG was not great as a threadpool Differential Revision: [D55712512](https://our.internmc.facebook.com/intern/diff/D55712512/) ghstack-source-id: 221183910 Pull Request resolved: #2839
iseeyuan
approved these changes
Apr 4, 2024
|
This pull request has been merged in 923f2d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
My local M1 runs reveal that GCG was not great as a threadpool
Differential Revision: D55712512