Skip to content

resolve_buck.py: Add an entry for darwin-x86_64 #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Apr 5, 2024

Copy link

pytorch-bot bot commented Apr 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2868

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 011d5c0 with merge base 92b5cfc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2024
@dbort dbort requested a review from GregoryComer April 5, 2024 05:04
@dbort
Copy link
Contributor Author

dbort commented Apr 5, 2024

I'm away from my work machine til next week so I won't be able to land this myself until then, so please clone/commandeer this PR if you think it'll be useful.

@GregoryComer
Copy link
Member

GregoryComer commented Apr 6, 2024

Thanks for grabbing the version hash! I'm intending to land this and then cherry-pick onto 0.2. Should alleviate potential pain for Intel mac users, since we removed the buck download information (perhaps prematurely?).

@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer
Copy link
Member

@pytorchbot cherry-pick --onto release/0.2 -c critical

@facebook-github-bot
Copy link
Contributor

@GregoryComer merged this pull request in de7fdaa.

@GregoryComer
Copy link
Member

GregoryComer commented Apr 10, 2024

Trying again, since it seems like it didn't work. Maybe because I triggered the cherry-pick before the bot registered that it landed?

@pytorchbot cherry-pick --onto release/0.2 -c critical

pytorchbot pushed a commit that referenced this pull request Apr 10, 2024
Summary:
Version hash reported by
https://github.com/facebook/buck2/releases/download/2024-02-15/buck2-x86_64-apple-darwin.zst

Pull Request resolved: #2868

Reviewed By: Olivia-liu

Differential Revision: D55914146

Pulled By: GregoryComer

fbshipit-source-id: b9882900acfd4cb6f74eda90a7c99bdb119ec122
(cherry picked from commit de7fdaa)
@pytorchbot
Copy link
Collaborator

Cherry picking #2868

The cherry pick PR is at #2960 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

mergennachin pushed a commit that referenced this pull request Apr 10, 2024
Summary:
Version hash reported by
https://github.com/facebook/buck2/releases/download/2024-02-15/buck2-x86_64-apple-darwin.zst

Pull Request resolved: #2868

Reviewed By: Olivia-liu

Differential Revision: D55914146

Pulled By: GregoryComer

fbshipit-source-id: b9882900acfd4cb6f74eda90a7c99bdb119ec122
(cherry picked from commit de7fdaa)
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants