Add macros and helper classes in event_tracer needed for profiling #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
tarun292
force-pushed
the
export-D49204729
branch
2 times, most recently
from
6113f7c to
4bcb716
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
tarun292
force-pushed
the
export-D49204729
branch
from
4bcb716 to
de59943
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
tarun292
force-pushed
the
export-D49204729
branch
from
de59943 to
d1efb70
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
tarun292
force-pushed
the
export-D49204729
branch
from
d1efb70 to
0dc74bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
tarun292
force-pushed
the
export-D49204729
branch
from
0dc74bf to
3e06aee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
…294) Summary: All the internal invocations (inside ExecuTorch codebase) of event_tracer will be controlled through the macros added in this diff. The benefit of this is that we can leave these hooks in the hot path and when the flag is disabled they essentially compile to a no-op in prod releases. It's also ensured that in all these macros if we pass in a `nullptr` as event_tracer (default case if user doesn't pass in one when method is created) we just return immediately. The specific macros added here are only meant to be used inside the ExecuTorch codebase as the header explains. Reviewed By: dbort Differential Revision: D49204729
tarun292
force-pushed
the
export-D49204729
branch
from
3e06aee to
ad6c854
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49204729 |
|
This pull request has been merged in 1bf2ff4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All the internal invocations (inside ExecuTorch codebase) of event_tracer will be controlled through the macros added in this diff. The benefit of this is that we can leave these hooks in the hot path and when the flag is disabled they essentially compile to a no-op in prod releases.
It's also ensured that in all these macros if we pass in a
nullptras event_tracer (default case if user doesn't pass in one when method is created) we just return immediately.The specific macros added here are only meant to be used inside the ExecuTorch codebase as the header explains.
Differential Revision: D49204729