Consolidate tokenizer interface #2954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2954
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 727b0ca with merge base 554cd27 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55944780 |
larryliu0820
added a commit
that referenced
this pull request
Apr 10, 2024
Summary: Change the tokenizer APIs to: ``` Result<std::vector<uint64_t>> encode(const std::string& input, int8_t bos, int8_t eos); Result<std::string> decode(uint64_t prev_token, uint64_t token); ``` Notice that: we use `uint64_t` for token id just to be safe. We return a std::vector of tokens for encode() API. Differential Revision: D55944780
larryliu0820
force-pushed
the
export-D55944780
branch
from
c191ce7 to
15144bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55944780 |
lucylq
approved these changes
Apr 10, 2024
Summary: Change the tokenizer APIs to: ``` Result<std::vector<uint64_t>> encode(const std::string& input, int8_t bos, int8_t eos); Result<std::string> decode(uint64_t prev_token, uint64_t token); ``` Notice that: we use `uint64_t` for token id just to be safe. We return a std::vector of tokens for encode() API. Reviewed By: lucylq Differential Revision: D55944780
facebook-github-bot
force-pushed
the
export-D55944780
branch
from
15144bd to
727b0ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55944780 |
|
This pull request has been merged in 948760a. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Change the tokenizer APIs to:
Notice that: we use
uint64_tfor token id just to be safe. We return a std::vector of tokens for encode() API.Differential Revision: D55944780