Handle multiple memory IDs using pid #2974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2974
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55ec176 with merge base 0f5794e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
kimishpatel
approved these changes
Apr 16, 2024
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
74c31ba to
1e69c47
Compare
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Apr 16, 2024
Summary: Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, hsharma35 Differential Revision: D55494986
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 23, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
1e69c47 to
5a8cff1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
5a8cff1 to
1265f75
Compare
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, hsharma35 Differential Revision: D55494986
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
1265f75 to
cebaa52
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
cebaa52 to
edb48bb
Compare
Olivia-liu
approved these changes
Jul 30, 2024
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
edb48bb to
580d14d
Compare
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
580d14d to
d145904
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
d145904 to
fd31178
Compare
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 31, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 31, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
fd31178 to
fb0f269
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Jul 31, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
fb0f269 to
80643b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
80643b8 to
7112894
Compare
skrtskrtfb
pushed a commit
to skrtskrtfb/executorch
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
Differential Revision: D55432084
Differential Revision: D55455168
Summary: Pull Request resolved: pytorch#2974 Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read. Reviewed By: kimishpatel, Olivia-liu, hsharma35 Differential Revision: D55494986
|
This pull request was exported from Phabricator. Differential Revision: D55494986 |
skrtskrtfb
force-pushed
the
export-D55494986
branch
from
7112894 to
55ec176
Compare
|
This pull request has been merged in f52d8ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Handle multiple memory IDs by dumping them into different processes in trace view. This solution seemed the simplest, and since the time stamps match between processes it should be fairly straightforward to look through
An alternate solution I attempted was to place different memory spaces across each other separated by some horizontal "space". However, it quickly became ugly/difficult to differentiate which allocation was on which memory space - I think the above solution is probably the easier one to read.
Reviewed By: kimishpatel, hsharma35
Differential Revision: D55494986