Skip to content

Dynamic Conv1d + W2L #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Dynamic Conv1d + W2L #2976

wants to merge 1 commit into from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Apr 10, 2024

Summary:
Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai

Differential Revision: D55815092

Copy link

pytorch-bot bot commented Apr 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2976

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit b121bc3 with merge base 49d1f02 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 10, 2024
Summary:
Pull Request resolved: pytorch#2976

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai

Differential Revision: D55815092
@mcr229 mcr229 force-pushed the export-D55815092 branch from dea37ce to badff43 Compare April 10, 2024 23:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

@mcr229 mcr229 force-pushed the export-D55815092 branch from badff43 to 6321c5e Compare April 11, 2024 00:14
mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 11, 2024
Summary:
Pull Request resolved: pytorch#2976

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai

Differential Revision: D55815092
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 11, 2024
Summary:
Pull Request resolved: pytorch#2976

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai

Differential Revision: D55815092
@mcr229 mcr229 force-pushed the export-D55815092 branch from 6321c5e to cfa6756 Compare April 11, 2024 17:24
mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 11, 2024
Summary:
Pull Request resolved: pytorch#2976

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai, kirklandsign

Differential Revision: D55815092
@mcr229 mcr229 force-pushed the export-D55815092 branch from cfa6756 to add2311 Compare April 11, 2024 21:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

@mcr229 mcr229 force-pushed the export-D55815092 branch from add2311 to 584267f Compare April 15, 2024 23:01
mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 15, 2024
Summary:

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai, kirklandsign

Differential Revision: D55815092
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

mcr229 added a commit to mcr229/executorch that referenced this pull request Apr 15, 2024
Summary:

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai, kirklandsign

Differential Revision: D55815092
@mcr229 mcr229 force-pushed the export-D55815092 branch from 584267f to a457e42 Compare April 15, 2024 23:02
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

Summary:

Conv1d uses static reshape operator, in order to convert 3d tensor to 4d tensor so xnnpack can operate using conv2d.

For dynamism, reshape only accepts a single dynamic dimension, which is denoted as dynamic with a dim of 0.

Reviewed By: digantdesai, kirklandsign

Differential Revision: D55815092
@mcr229 mcr229 force-pushed the export-D55815092 branch from a457e42 to b121bc3 Compare April 15, 2024 23:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55815092

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7b375fe.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants