[CoreML Backend] Handle missing data types. #2984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2984
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e19fef3 with merge base b341223 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Apr 11, 2024
|
Didn't find following labels among repository labels: ci/trunkflow |
|
@pytorchbot label ciflow/trunk |
cymbalrush
force-pushed
the
fix_data_types
branch
from
3647722 to
3b6f249
Compare
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
force-pushed
the
fix_data_types
branch
from
3b6f249 to
22f23bc
Compare
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
force-pushed
the
fix_data_types
branch
5 times, most recently
from
8c6b612 to
e110e6d
Compare
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey just to confirm, does this version work with simulator or real device only? |
Yes, it should work with simulator. |
cymbalrush
force-pushed
the
fix_data_types
branch
from
e110e6d to
e19fef3
Compare
|
Tested on iPhone 15 Pro, iOS 17.4
|
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin merged this pull request in d731866. |
|
@pytorchbot cherry-pick --onto release/0.2 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866)
Cherry picking #2984The cherry pick PR is at #3134 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
cymbalrush
added a commit
that referenced
this pull request
Apr 18, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866)
cymbalrush
added a commit
that referenced
this pull request
Apr 18, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866)
cymbalrush
added a commit
that referenced
this pull request
Apr 22, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866)
cymbalrush
added a commit
that referenced
this pull request
Apr 22, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866)
guangy10
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: **Changes** - The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if `CoreMLBackend` can export a model then runtime would execute it. Complex types are not supported because `coremltools` doesn't support it. - Improves and cleans the multiarray copying code. - Adds portable ops to CoreML executor so that it can run a partitioned model. **Testing** - Tested partitioned model `coreml_stories.pte` - Added multiarray copying tests. Pull Request resolved: #2984 Reviewed By: kirklandsign Differential Revision: D56003795 Pulled By: shoumikhin fbshipit-source-id: fa1c7846f9510d68c359aed6761aedb2d10c6f46 (cherry picked from commit d731866) Co-authored-by: Gyan Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The runtime was failing if it encountered a datatype not supported by CoreML framework. The changes add support for all the datatypes that are supported by coremltools basically if
CoreMLBackendcan export a model then runtime would execute it. Complex types are not supported becausecoremltoolsdoesn't support it.Improves and cleans the multiarray copying code.
Adds portable ops to CoreML executor so that it can run a partitioned model.
Testing
coreml_stories.pte