Skip to content

Make Default Testing Config Canonical Config #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Sep 13, 2023

Summary: For Tester and our long term testing, we should be using the canonical capture config, so we are testing the right way

Differential Revision: D49214927

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@mcr229 mcr229 force-pushed the export-D49214927 branch 2 times, most recently from dfec20e to dcb6faf Compare September 13, 2023 22:54
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

mcr229 and others added 8 commits September 13, 2023 16:42
Differential Revision: D48761858

fbshipit-source-id: 0750cfb2facd2db4fe8ace84eaf39fc614fa9480
Differential Revision: D48761859

fbshipit-source-id: 5fb3a9f6fcfdaa4db3bfd8d2c84ac35539702f1a
Differential Revision: D48790083

fbshipit-source-id: e1081b3904bdb33c1dfb8d4337c818ec5d65144a
Differential Revision: D48764114

fbshipit-source-id: 57a95e0ea37d36075c5fb34e4e44bf927c1ae8ea
Differential Revision: D48805091

fbshipit-source-id: 84f9cf0ce782163fd63ad6ebb1c5a67326da1306
Differential Revision: D48805092

fbshipit-source-id: badf1ccb910ab1ecb4137d2e3df37dc84b4a6123
Differential Revision: D49214926

fbshipit-source-id: a2dbba20bd24874f26d91c26d3550dee3d316f82
Summary:
Pull Request resolved: pytorch/executorch#303

For Tester and our long term testing, we should be using the canonical capture config, so we are testing the right way

Reviewed By: digantdesai, kirklandsign

Differential Revision: D49214927

fbshipit-source-id: 12f165dacc2caf557b03e3b1ae3b487bcd8836ca
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49214927

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4923faf.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants