remove short-term quant #305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
mcr229
force-pushed
the
export-D48761858
branch
from
5955897 to
dea2a5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
mcr229
force-pushed
the
export-D48761858
branch
from
dea2a5c to
8133984
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
mcr229
force-pushed
the
export-D48761858
branch
from
8133984 to
99b94a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
mcr229
force-pushed
the
export-D48761858
branch
from
99b94a2 to
897d6c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
mcr229
force-pushed
the
export-D48761858
branch
from
897d6c9 to
de6f5d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
Summary: Deprecating Short Term quant flow in new testing infra Reviewed By: salilsdesai Differential Revision: D48761858
mcr229
force-pushed
the
export-D48761858
branch
from
de6f5d2 to
bd5a798
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48761858 |
|
This pull request has been merged in 3e78b2f. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Summary: It handles the case hhen params.json is explicitly given and the json doesn't contain mention about tokenizer config, but the command line does. Test Plan: python torchchat.py generate --device cpu --checkpoint-path /Users/mnachin/models/Meta-Llama-3-8B/original/consolidated.00.pth --params-path=/Users/mnachin/models/Meta-Llama-3-8B/original/params.json --temperature 0 --tiktoken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Deprecating Short Term quant flow in new testing infra
Reviewed By: salilsdesai
Differential Revision: D48761858