move quant_params class out of quant_utils #308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
mcr229
force-pushed
the
export-D48805091
branch
from
24ba074 to
72cd8bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
mcr229
force-pushed
the
export-D48805091
branch
from
72cd8bc to
a576f87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
mcr229
force-pushed
the
export-D48805091
branch
2 times, most recently
from
a205461 to
1925020
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
mcr229
force-pushed
the
export-D48805091
branch
from
1925020 to
893d2e6
Compare
Differential Revision: D48761858 fbshipit-source-id: 8a1aecd283867aedbc293ae32a52808ebd9e580f
Differential Revision: D48761859 fbshipit-source-id: 8093709d42a3f8a6e056fddd3770571bc309b0e9
Differential Revision: D48790083 fbshipit-source-id: 2b39e333ead6b0ac53b52508d16b4621b66a40e3
Differential Revision: D48764114 fbshipit-source-id: 9cbb22848112faf15b9423cf7589e2979f48dd7a
Summary: Pull Request resolved: pytorch/executorch#308 Quant Params always felt a little weird being in quant utils. Additionally in the next diff, we will have a dependency on implicit q/dq pass which will cause a circular dependency with quant_utils. So we move QuantParams out of utils and into its own file next to node_visitor Reviewed By: digantdesai, salilsdesai Differential Revision: D48805091 fbshipit-source-id: a4954328b16d332495d06eff71f61fa56b82da89
|
This pull request was exported from Phabricator. Differential Revision: D48805091 |
mcr229
force-pushed
the
export-D48805091
branch
from
893d2e6 to
036a680
Compare
|
This pull request has been merged in 7bfec8f. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Ali Khosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Quant Params always felt a little weird being in quant utils. Additionally in the next diff, we will have a dependency on implicit q/dq pass which will cause a circular dependency with quant_utils. So we move QuantParams out of utils and into its own file next to node_visitor
Reviewed By: digantdesai, salilsdesai
Differential Revision: D48805091