Skip to content

Tie quantization of add operands and result together #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Tie quantization of add operands and result together #3091

wants to merge 2 commits into from

Conversation

per
Copy link
Collaborator

@per per commented Apr 17, 2024

Change-Id: Ie2662ebd6555821fa1d813163daf4b209a319b44

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3091

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit bbd3ac3 with merge base 910f851 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-arm-backend-delegation / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/portable/cpu/vec_ops.h:133:33: error: ambiguous overload for 'operator*' (operand types are 'const torch::executor::Half' and 'const int8_t' {aka 'const signed char'})

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2024
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 17, 2024
@per per requested a review from digantdesai April 17, 2024 19:02
per added 2 commits April 18, 2024 08:56
@per
Tie quantization of add operands and result together
7b632ed 
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ie2662ebd6555821fa1d813163daf4b209a319b44
@per
Move Vela to new revision
bbd3ac3 
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I798948b233f42b2dc23e061f0654c02963cdd668
@per per force-pushed the arm_quantizer_add branch from 6d3742e to bbd3ac3 Compare April 18, 2024 06:56
digantdesai
digantdesai reviewed Apr 18, 2024
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 8b1f49a.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Closed
@per per deleted the arm_quantizer_add branch July 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@per @facebook-github-bot @digantdesai