DynamicShim for dlsym user #3136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3136
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c269e9 with merge base de0c233 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
force-pushed
the
export-D55025594
branch
from
6367852 to
20bd0e0
Compare
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 19, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 19, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
kirklandsign
force-pushed
the
export-D55025594
branch
from
20bd0e0 to
fbe0132
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 19, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
kirklandsign
force-pushed
the
export-D55025594
branch
from
fbe0132 to
c3d1296
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 19, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
kirklandsign
force-pushed
the
export-D55025594
branch
from
c3d1296 to
1834541
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 23, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
kirklandsign
force-pushed
the
export-D55025594
branch
from
1834541 to
3b805fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 23, 2024
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Differential Revision: D55025594
kirklandsign
force-pushed
the
export-D55025594
branch
from
3b805fa to
e9d81d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
cccclai
reviewed
Apr 24, 2024
cccclai
approved these changes
Apr 24, 2024
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add a shim layer so that users just need the header and load the symbol with dlsym. we will have two libraries: - header, where declarations and class (shim) are to be compiled with their codebase statically. Want to keep this minimal. - implementation, which pulls in the ET libraries and shim implementation. It’s compiled separately as a .so file and they can load and find symbols with dlopen and dlsym. Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen. For users, they can now only load the so library, and just use dysym to look for exposed API `create_executorch_dynamic_shim` and `free_executorch_dynamic_shim`, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details. Reviewed By: kimishpatel Differential Revision: D55025594 Pulled By: kirklandsign
kirklandsign
force-pushed
the
export-D55025594
branch
from
67a59d9 to
7c269e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55025594 |
|
@kirklandsign merged this pull request in b5bb921. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a shim layer so that users just need the header and load the symbol with dlsym.
we will have two libraries:
Note that users only need to compile the header dynamic_shim.h into their code in compile time. dynamic_shim.h contains minimal dependency from ExecuTorch, so it won't impact static time binary size or startup time. The actual implementation dynamic_shim_impl is compiled into a separate shared library, which has all the ExecuTorch libraries. The shared library can be loaded later with dlopen.
For users, they can now only load the so library, and just use dysym to look for exposed API
create_executorch_dynamic_shimandfree_executorch_dynamic_shim, and use API code in DynamicShim (as a pointer to an interface), and the DynamicShimImpl will invoke the actual ET Module code in its implementation details.Differential Revision: D55025594