Add a pure python wrapper fo pybindings.portable_lib #3137

dbort · 2024-04-18T19:07:45Z

Summary:
When installed as a pip wheel, we must import torch before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies.

So, add a pure python wrapper that lets us do this when users say import executorch.extension.pybindings.portable_lib

We only need this for OSS, so don't bother doing this for other pybindings targets.

Differential Revision: D56317150

pytorch-bot · 2024-04-18T19:07:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3137

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d20118 with merge base 90d0c1a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-04-18T19:07:57Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-18T20:38:38Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-18T20:41:59Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-18T21:40:22Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-18T21:42:18Z

This pull request was exported from Phabricator. Differential Revision: D56317150

Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-20T00:50:42Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

facebook-github-bot · 2024-04-20T00:51:04Z

This pull request was exported from Phabricator. Differential Revision: D56317150

…en,portable}_lib (#3137) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Differential Revision: D56317150

mikekgfb

Thank you!

larryliu0820

Looks good. I’m thinking is there a way to setup a test? I want to see if we are giving proper error message to user, if they don’t have torch installed properly.

orionr

Looks good! Did a real review here.

orionr · 2024-04-20T01:25:47Z

extension/pybindings/portable_lib.py

+# the pybindings shared library extension. This will load libtorch.so and
+# related libs, ensuring that the pybindings lib can resolve those runtime
+# dependencies.
+import torch as _torch


Do we rely on ATen for the pybind? I'm guessing including torch here is going to pull all of that in. Okay, but just checking

We do, so that users can use normal torch tensors for their inputs and outputs, making it easier for them to use.

orionr · 2024-04-20T01:26:17Z

extension/pybindings/TARGETS

@@ -46,8 +46,9 @@ executorch_pybindings(
 executorch_pybindings(
    compiler_flags = ["-std=c++17"],
    cppdeps = PORTABLE_MODULE_DEPS + MODELS_ATEN_OPS_LEAN_MODE_GENERATED_LIB,
-    python_module_name = "portable_lib",
-    types = ["//executorch/extension/pybindings:pybindings_types_gen[portable_lib.pyi]"],
+    # Give this an underscore prefix because it has a pure python wrapper.


I must say this is pretty cool

Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150

facebook-github-bot · 2024-04-22T16:50:11Z

This pull request was exported from Phabricator. Differential Revision: D56317150

Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150

facebook-github-bot · 2024-04-22T16:51:08Z

This pull request was exported from Phabricator. Differential Revision: D56317150

) Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150

Summary: When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150

facebook-github-bot · 2024-04-22T19:27:37Z

This pull request was exported from Phabricator. Differential Revision: D56317150

facebook-github-bot · 2024-04-22T21:02:38Z

This pull request has been merged in 969aa96.

dbort · 2024-04-22T21:30:41Z

@pytorchbot cherry-pick --onto release/0.2 -c release

Summary: Pull Request resolved: #3137 When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150 fbshipit-source-id: 920382636732aa276c25a76163afb7d28b1846d0 (cherry picked from commit 969aa96)

pytorchbot · 2024-04-22T21:35:09Z

Cherry picking #3137

The cherry pick PR is at #3218

Details for Dev Infra team

Raised by workflow job

Summary: Pull Request resolved: #3137 When installed as a pip wheel, we must import `torch` before trying to import the pybindings shared library extension. This will load libtorch.so and related libs, ensuring that the pybindings lib can resolve those runtime dependencies. So, add a pure python wrapper that lets us do this when users say `import executorch.extension.pybindings.portable_lib` We only need this for OSS, so don't bother doing this for other pybindings targets. Reviewed By: orionr, mikekgfb Differential Revision: D56317150 fbshipit-source-id: 920382636732aa276c25a76163afb7d28b1846d0 (cherry picked from commit 969aa96) Co-authored-by: Dave Bort <[email protected]>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024

facebook-github-bot added the fb-exported label Apr 18, 2024

dbort force-pushed the export-D56317150 branch from 32eacf2 to fc3ed1f Compare April 18, 2024 20:38

dbort force-pushed the export-D56317150 branch from fc3ed1f to 6fbb967 Compare April 18, 2024 20:41

dbort force-pushed the export-D56317150 branch from 6fbb967 to 72c1c39 Compare April 18, 2024 21:40

dbort force-pushed the export-D56317150 branch from 72c1c39 to 3a6280d Compare April 18, 2024 21:42

dbort force-pushed the export-D56317150 branch from 3a6280d to 681f2bd Compare April 20, 2024 00:50

dbort force-pushed the export-D56317150 branch from 681f2bd to a26ca55 Compare April 20, 2024 00:50

mikekgfb approved these changes Apr 20, 2024

View reviewed changes

dbort changed the title ~~Add a pure python wrapper fo pybindings.{aten,portable}_lib~~ Add a pure python wrapper fo pybindings.portable_lib Apr 20, 2024

larryliu0820 approved these changes Apr 20, 2024

View reviewed changes

orionr approved these changes Apr 20, 2024

View reviewed changes

dbort force-pushed the export-D56317150 branch from a26ca55 to 797f608 Compare April 22, 2024 16:49

dbort force-pushed the export-D56317150 branch from 797f608 to 700e5fa Compare April 22, 2024 16:50

dbort force-pushed the export-D56317150 branch from 700e5fa to 5d20118 Compare April 22, 2024 19:27

facebook-github-bot closed this in 969aa96 Apr 22, 2024

facebook-github-bot added the Merged label Apr 22, 2024

dbort deleted the export-D56317150 branch April 22, 2024 21:31

dbort mentioned this pull request Apr 22, 2024

[v0.2.0] Release Tracker #2666

Closed

This was referenced Apr 25, 2024

fix llama readme #3339

Closed

disclaimer #3376

Closed

Add a pure python wrapper fo pybindings.portable_lib #3137

Add a pure python wrapper fo pybindings.portable_lib #3137

Uh oh!

Conversation

dbort commented Apr 18, 2024

Uh oh!

pytorch-bot bot commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3137

✅ No Failures

Uh oh!

facebook-github-bot commented Apr 18, 2024

Uh oh!

facebook-github-bot commented Apr 18, 2024

Uh oh!

facebook-github-bot commented Apr 18, 2024

Uh oh!

facebook-github-bot commented Apr 18, 2024

Uh oh!

facebook-github-bot commented Apr 18, 2024

Uh oh!

facebook-github-bot commented Apr 20, 2024

Uh oh!

facebook-github-bot commented Apr 20, 2024

Uh oh!

mikekgfb left a comment

Choose a reason for hiding this comment

Uh oh!

larryliu0820 left a comment

Choose a reason for hiding this comment

Uh oh!

orionr left a comment

Choose a reason for hiding this comment

Uh oh!

orionr Apr 20, 2024

Choose a reason for hiding this comment

Uh oh!

dbort Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

orionr Apr 20, 2024

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 22, 2024

Uh oh!

facebook-github-bot commented Apr 22, 2024

Uh oh!

facebook-github-bot commented Apr 22, 2024

Uh oh!

facebook-github-bot commented Apr 22, 2024

Uh oh!

dbort commented Apr 22, 2024

Uh oh!

pytorchbot commented Apr 22, 2024

Cherry picking #3137

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 18, 2024 •

edited

Loading