Update how we input kwargs #314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 13, 2023
Summary: X-link: pytorch/executorch#314 Previously, the code for passing inputs to exported program was: ``` if kwargs: return (args, kwargs) else: return args ``` However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments. So I updated the code to just always keep the kwargs around cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng Differential Revision: D49218534 Pulled By: angelayi
angelayi
force-pushed
the
export-D49218534
branch
from
38f1aab to
c649912
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 15, 2023
Summary: X-link: pytorch/executorch#314 Previously, the code for passing inputs to exported program was: ``` if kwargs: return (args, kwargs) else: return args ``` However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments. So I updated the code to just always keep the kwargs around cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng Reviewed By: zhxchen17 Differential Revision: D49218534 Pulled By: angelayi
angelayi
force-pushed
the
export-D49218534
branch
from
c649912 to
2abf1fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
angelayi
force-pushed
the
export-D49218534
branch
2 times, most recently
from
2c8dc34 to
02b0b9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 15, 2023
Summary: X-link: pytorch/executorch#314 Previously, the code for passing inputs to exported program was: ``` if kwargs: return (args, kwargs) else: return args ``` However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments. So I updated the code to just always keep the kwargs around cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng Reviewed By: zhxchen17 Differential Revision: D49218534 Pulled By: angelayi
angelayi
force-pushed
the
export-D49218534
branch
from
02b0b9e to
4e11669
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
angelayi
force-pushed
the
export-D49218534
branch
from
4e11669 to
89b8d84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
angelayi
force-pushed
the
export-D49218534
branch
from
89b8d84 to
8fdc23a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 18, 2023
Summary: X-link: pytorch/executorch#314 Previously, the code for passing inputs to exported program was: ``` if kwargs: return (args, kwargs) else: return args ``` However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments. So I updated the code to just always keep the kwargs around cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng Reviewed By: zhxchen17 Differential Revision: D49218534 Pulled By: angelayi
angelayi
force-pushed
the
export-D49218534
branch
from
8fdc23a to
49468c3
Compare
Summary:
Previously, the code for passing inputs to exported program was:
```
if kwargs:
return (args, kwargs)
else:
return args
```
However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments.
So I updated the code to just always keep the kwargs around
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
X-link: pytorch/pytorch#109160
Reviewed By: zhxchen17
Differential Revision: D49218534
Pulled By: angelayi
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
angelayi
force-pushed
the
export-D49218534
branch
from
49468c3 to
e4f738a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218534 |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the code for passing inputs to exported program was:
However, this causes some inconsistency where if the original input contains args and kwargs, the treespec would be a tuple containing a tuple of arguments, and a dictionary of keyword arguments. But if the original input only contained args, the treespec would just be a tuple of arguments.
So I updated the code to just always keep the kwargs around
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng
X-link: pytorch/pytorch#109160
Differential Revision: D49218534
Pulled By: angelayi