Make sdk/executor_runner use MethodMeta interface and adjust non-const indices #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49208017 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D49208017 |
|
This pull request was exported from Phabricator. Differential Revision: D49208017 |
Summary: First step in hiding the off-by-one non-const buffer indices from users. Since fewer users use `MethodMeta::num_non_const_buffers` today (relative to the version on Program), update the behavior here, along with all of its users. After this, we can migrate the users of `Program::get_non_const_buffer_size` to this new API, fixing the off-by-one as we go. Differential Revision: D48762563 fbshipit-source-id: aeb4a69ff3927be2146b491051356ae3ccf5be62
Summary: Make this use the new APIs. Note that MethodMeta::num_non_const_buffers is zero-based, so we can avoid the hacks that skip index zero. Differential Revision: https://internalfb.com/D48762565 fbshipit-source-id: 637983ac30140235360fb4ad3605b91c8ca67a51
Summary: Using MethodMeta lets us avoid the off-by-one hack used by the (deprecated) Program versions of the buffer iterators. While I'm here, stop using runtime_allocator to create the outputs list: it's not legal to touch the runtime_allocator after the Method is created. Differential Revision: D48762562 fbshipit-source-id: aecda4cd7521c99f25721a2c25db56f704457168
|
This pull request was exported from Phabricator. Differential Revision: D49208017 |
|
This pull request has been merged in a404e28. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Not sure if these are exactly right, but putting up a patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The new MethodMeta interface avoids the need to adjust non-const buffer indices by 1.
Differential Revision: D49208017