Add allocate_temp method to KernelRuntimeContext #3209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3209
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9b2839b with merge base 783e932 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56421957 |
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
Apr 22, 2024
Summary: This adds an `allocate_temp` method to KernelRuntimeContext, and passes the temporary memory allocator from `execute_instruction`. The method returns a result that errors if the temporary `MemoryAllocator` was not provided or the memory could not be allocated. Differential Revision: D56421957
davidlin54
force-pushed
the
export-D56421957
branch
from
6ac99a1 to
16ffb0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56421957 |
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
Apr 22, 2024
Summary: This adds an `allocate_temp` method to KernelRuntimeContext, and passes the temporary memory allocator from `execute_instruction`. The method returns a result that errors if the temporary `MemoryAllocator` was not provided or the memory could not be allocated. Differential Revision: D56421957
davidlin54
force-pushed
the
export-D56421957
branch
from
16ffb0b to
509cd35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56421957 |
dbort
approved these changes
Apr 23, 2024
davidlin54
force-pushed
the
export-D56421957
branch
from
509cd35 to
81dbd06
Compare
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
Apr 23, 2024
Summary: This adds an `allocate_temp` method to KernelRuntimeContext, and passes the temporary memory allocator from `execute_instruction`. The method returns a result that errors if the temporary `MemoryAllocator` was not provided or the memory could not be allocated. Reviewed By: dbort Differential Revision: D56421957
|
This pull request was exported from Phabricator. Differential Revision: D56421957 |
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
Apr 23, 2024
Summary: This adds an `allocate_temp` method to KernelRuntimeContext, and passes the temporary memory allocator from `execute_instruction`. The method returns a result that errors if the temporary `MemoryAllocator` was not provided or the memory could not be allocated. Reviewed By: dbort Differential Revision: D56421957
davidlin54
force-pushed
the
export-D56421957
branch
from
81dbd06 to
391d670
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56421957 |
Summary: Pull Request resolved: pytorch#3209 This adds an `allocate_temp` method to KernelRuntimeContext, and passes the temporary memory allocator from `execute_instruction`. The method returns a result that errors if the temporary `MemoryAllocator` was not provided or the memory could not be allocated. Reviewed By: dbort Differential Revision: D56421957
davidlin54
force-pushed
the
export-D56421957
branch
from
391d670 to
9b2839b
Compare
|
This pull request has been merged in 719b368. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This adds an
allocate_tempmethod to KernelRuntimeContext, and passes the temporary memory allocator fromexecute_instruction. The method returns a result that errors if the temporaryMemoryAllocatorwas not provided or the memory could not be allocated.Differential Revision: D56421957