[ET-VK][9/n] clone node #3219
Closed
[ET-VK][9/n] clone node #3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3219
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d11e62 with merge base de0c233 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56441547 |
yipjustin
added a commit
that referenced
this pull request
Apr 22, 2024
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) ghstack-source-id: 223471608 Pull Request resolved: #3219
jorgep31415
approved these changes
Apr 22, 2024
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) [ghstack-poisoned]
Closed
yipjustin
added a commit
that referenced
this pull request
Apr 23, 2024
Pull Request resolved: #3219 Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) ghstack-source-id: 223528987
|
This pull request was exported from Phabricator. Differential Revision: D56441547 |
SS-JIA
approved these changes
Apr 23, 2024
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D56441547 |
yipjustin
added a commit
that referenced
this pull request
Apr 24, 2024
Pull Request resolved: #3219 Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. ghstack-source-id: 223694720 Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/)
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D56441547 |
yipjustin
added a commit
that referenced
this pull request
Apr 24, 2024
Pull Request resolved: #3219 Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. ghstack-source-id: 223694720 Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/)
Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/) [ghstack-poisoned]
yipjustin
added a commit
that referenced
this pull request
Apr 24, 2024
Pull Request resolved: #3219 Introduce a clone node for copy operation. Also register `aten.clone` to this node. Important to note that during model export, possible to point the lvalue of `aten.clone` to the underlying shared object of the rvalue to achieve no-copy. ghstack-source-id: 223698862 Differential Revision: [D56441547](https://our.internmc.facebook.com/intern/diff/D56441547/)
|
This pull request was exported from Phabricator. Differential Revision: D56441547 |
|
This pull request has been merged in 2dac5f3. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduce a clone node for copy operation.
Also register
aten.cloneto this node. Important to note that during model export, possible to point the lvalue ofaten.cloneto the underlying shared object of the rvalue to achieve no-copy.Differential Revision: D56441547