Bump torchfix from 0.1.1 to 0.5.0 #3220
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [torchfix](https://github.com/pytorch-labs/torchfix) from 0.1.1 to 0.5.0. - [Release notes](https://github.com/pytorch-labs/torchfix/releases) - [Commits](https://github.com/pytorch-labs/torchfix/commits/v0.5.0) --- updated-dependencies: - dependency-name: torchfix dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
Dependabot tried to add |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3220
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9b0874b with merge base dbf90c2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
force-pushed
the
dependabot/pip/torchfix-0.5.0
branch
from
797199c to
1a3e1f5
Compare
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
There are some additional linter fixes after the upgrade. |
| @@ -109,7 +109,9 @@ def SSD300VGG16(pretrained_weight_model): | |||
| from model import SSD300 | |||
|
|
|||
| model = SSD300(n_classes=21) | |||
| checkpoint = torch.load(pretrained_weight_model, map_location="cpu") | |||
| checkpoint = torch.load( | |||
| pretrained_weight_model, map_location="cpu", weights_only=False | |||
There was a problem hiding this comment.
Wouldn't weights_only=True work here and in other places?
weights_only=False is a potential security issue.
I guess it's fine to don't cause any compatibility problems right now, but maybe add a TODO to investigate later?
There was a problem hiding this comment.
Let me add them as TODO then, these are examples from different partners, so I guess setting weights_only to True would better be reviewed separately.
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps torchfix from 0.1.1 to 0.5.0.
Release notes
Sourced from torchfix's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)