Manual LICM in op_convolution #3274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Otherwise, we require LTO for decent performance for this thing in kernels. Reviewed By: kimishpatel, manuelcandales Differential Revision: D56503573
Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own. Reviewed By: kimishpatel, manuelcandales Differential Revision: D56503574
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3274
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b1426e with merge base b7b40ac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56503574 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Apr 24, 2024
Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own. Reviewed By: kimishpatel, manuelcandales Differential Revision: D56503574
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Apr 24, 2024
Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own. Reviewed By: kimishpatel, manuelcandales Differential Revision: D56503574
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
Apr 24, 2024
Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own. Reviewed By: kimishpatel, manuelcandales Differential Revision: D56503574
|
to exported stacked diffs you want to use ghstack else it will combine changes from diff underneat |
kimishpatel
approved these changes
Apr 29, 2024
kimishpatel
approved these changes
Apr 29, 2024
|
This pull request has been merged in 987a1f9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Hoisting loads of these constants manually speeds up the kernel a lot. Depending on the types for CTYPE and CTYPE_BIAS, the compiler might not be able to prove this is safe on its own.
Reviewed By: kimishpatel, manuelcandales
Differential Revision: D56503574