Skip to content

[ET-VK][EZ] Fix conv2d_prepack_test #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[ET-VK][EZ] Fix conv2d_prepack_test #3415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions backends/vulkan/test/utils/test_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ void record_conv2d_prepack_weights_op(
api::VulkanBuffer& src_buffer,
vTensor& v_dst,
const std::vector<int64_t>& original_sizes,
const std::vector<int64_t>& padded_sizes,
const bool transposed) {
api::PipelineBarrier pipeline_barrier{};

Expand All @@ -80,8 +79,6 @@ void record_conv2d_prepack_weights_op(

api::UniformParamsBuffer original_sizes_ubo(
context, api::utils::make_ivec4(original_sizes, /*reverse = */ true));
api::UniformParamsBuffer padded_sizes_ubo(
context, api::utils::make_ivec2(padded_sizes, /*reverse = */ true));

api::SpecVarList specialization_constants = {};
context->submit_compute_job(
Expand All @@ -97,8 +94,7 @@ void record_conv2d_prepack_weights_op(
api::MemoryAccessType::WRITE),
src_buffer,
v_dst.sizes_ubo(),
original_sizes_ubo.buffer(),
padded_sizes_ubo.buffer());
original_sizes_ubo.buffer());
}

void record_binary_op(
Expand Down
1 change: 0 additions & 1 deletion backends/vulkan/test/utils/test_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ void record_conv2d_prepack_weights_op(
api::VulkanBuffer& src_buffer,
vTensor& v_dst,
const std::vector<int64_t>& original_sizes,
const std::vector<int64_t>& padded_sizes,
const bool transposed);

void record_binary_op(
Expand Down
1 change: 0 additions & 1 deletion backends/vulkan/test/vulkan_compute_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,7 +1633,6 @@ void test_conv2d(
staging_buffer_in.buffer(),
vten,
original_sizes,
padded_sizes,
transposed);
record_image_to_nchw_op(api::context(), vten, staging_buffer_out.buffer());

Expand Down