Add aten::pixel_shuffle.out portable variant #351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The executorch portable runtime was missing an implementation of `aten::pixel_shuffle.out`, which is used by the PiCA decoder. This is basically just a reshape operator, and I adapted the implementation from aten's `PixelShuffleKernel.cpp` after not using some helper functions that don't exist. I don't know much about how to make a more optimized implementation, or if there's a way to use parallelism automatically like the normal aten kernels do. Reviewed By: manuelcandales Differential Revision: D49173297
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49173297 |
|
This pull request has been merged in 1315a92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The executorch portable runtime was missing an implementation of
aten::pixel_shuffle.out,which is used by the PiCA decoder.
This is basically just a reshape operator, and I adapted the implementation from
aten's
PixelShuffleKernel.cppafter not using some helper functions that don't exist.I don't know much about how to make a more optimized implementation, or if there's a way
to use parallelism automatically like the normal aten kernels do.
Reviewed By: manuelcandales
Differential Revision: D49173297