Add lift constant tensors passes after aten_to_edge #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49207492 |
angelayi
force-pushed
the
export-D49207492
branch
from
6867190 to
467086f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49207492 |
angelayi
force-pushed
the
export-D49207492
branch
2 times, most recently
from
8eeed94 to
b28754a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49207492 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49207492 |
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Sep 18, 2023
…09382) Summary: X-link: pytorch/executorch#359 When exporting using enable_aot (through the torch.export path), we want to lift all constant tensors as buffers to the exported program. The ScalarToTensor pass in EXIR's aten_to_edge passes will create some constant tensors in the graph, so we will need to run a lift_constant_tensors pass afterwards. Note that this only needs to be applied when exporting using the torch.export path because in the original path, nothing is lifted. Test Plan: CI Reviewed By: cccclai Differential Revision: D49207492
Summary: X-link: pytorch/pytorch#109382 When exporting using enable_aot (through the torch.export path), we want to lift all constant tensors as buffers to the exported program. The ScalarToTensor pass in EXIR's aten_to_edge passes will create some constant tensors in the graph, so we will need to run a lift_constant_tensors pass afterwards. Note that this only needs to be applied when exporting using the torch.export path because in the original path, nothing is lifted. Reviewed By: cccclai Differential Revision: D49207492
angelayi
force-pushed
the
export-D49207492
branch
from
b28754a to
26dcb20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49207492 |
|
This pull request has been merged in e03bd6c. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 19, 2023
Summary: X-link: pytorch/executorch#359 When exporting using enable_aot (through the torch.export path), we want to lift all constant tensors as buffers to the exported program. The ScalarToTensor pass in EXIR's aten_to_edge passes will create some constant tensors in the graph, so we will need to run a lift_constant_tensors pass afterwards. Note that this only needs to be applied when exporting using the torch.export path because in the original path, nothing is lifted. Test Plan: CI Differential Revision: D49207492 Pull Request resolved: #109382 Approved by: https://github.com/cccclai
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When exporting using enable_aot (through the torch.export path), we want to lift all constant tensors as buffers to the exported program. The ScalarToTensor pass in EXIR's aten_to_edge passes will create some constant tensors in the graph, so we will need to run a lift_constant_tensors pass afterwards.
Note that this only needs to be applied when exporting using the torch.export path because in the original path, nothing is lifted.
Differential Revision: D49207492