Enable zero-size tensors #3640
Closed
Enable zero-size tensors #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3640
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b49c28d with merge base 46ec26b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57450473 |
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
May 16, 2024
Summary: As title. The approach is slightly different than in PyTorch Vulkan. Instead of binding no memory, we make a small allocation. The reason for this change is to account for the possibility that some zero size tensors are used as input but the output is not zero size. In that case we still need to be able to bind the zero size tensor to a shader. Differential Revision: D57450473
|
This pull request was exported from Phabricator. Differential Revision: D57450473 |
yipjustin
approved these changes
May 16, 2024
SS-JIA
added a commit
to SS-JIA/executorch-1
that referenced
this pull request
May 16, 2024
Summary: As title. The approach is slightly different than in PyTorch Vulkan. Instead of binding no memory, we make a small allocation. The reason for this change is to account for the possibility that some zero size tensors are used as input but the output is not zero size. In that case we still need to be able to bind the zero size tensor to a shader. Reviewed By: yipjustin Differential Revision: D57450473
|
This pull request was exported from Phabricator. Differential Revision: D57450473 |
Summary: As title. The approach is slightly different than in PyTorch Vulkan. Instead of binding no memory, we make a small allocation. The reason for this change is to account for the possibility that some zero size tensors are used as input but the output is not zero size. In that case we still need to be able to bind the zero size tensor to a shader. Reviewed By: yipjustin Differential Revision: D57450473
|
This pull request was exported from Phabricator. Differential Revision: D57450473 |
|
This pull request has been merged in 5c70121. |
copyrightly
added a commit
to copyrightly/executorch
that referenced
this pull request
May 23, 2024
Summary: `batch_norm` has been implemented in [PR 3569](pytorch#3569), but not registered due to 0-size tensors were not supported then. Since 0-size tensors are supported in [PR 3640](pytorch#3640), we can register this op now. Differential Revision: D57707822
facebook-github-bot
pushed a commit
that referenced
this pull request
May 23, 2024
Summary: Pull Request resolved: #3716 `batch_norm` has been implemented in [PR 3569](#3569), but not registered due to 0-size tensors were not supported then. Since 0-size tensors are supported in [PR 3640](#3640), we can register this op now. Reviewed By: jorgep31415 Differential Revision: D57707822 fbshipit-source-id: ec293adc29a4d16ea56d6cd7bba7a3b7fa4c7d6e
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
May 24, 2024
Summary: Pull Request resolved: pytorch#3716 `batch_norm` has been implemented in [PR 3569](pytorch#3569), but not registered due to 0-size tensors were not supported then. Since 0-size tensors are supported in [PR 3640](pytorch#3640), we can register this op now. Reviewed By: jorgep31415 Differential Revision: D57707822 fbshipit-source-id: ec293adc29a4d16ea56d6cd7bba7a3b7fa4c7d6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
The approach is slightly different than in PyTorch Vulkan. Instead of binding no memory, we make a small allocation. The reason for this change is to account for the possibility that some zero size tensors are used as input but the output is not zero size. In that case we still need to be able to bind the zero size tensor to a shader.
Differential Revision: D57450473