add handling of out-of-range indices to Slice #3689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3689
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 080024b with merge base 79e9b79 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57597106 |
nathanaelsee
added a commit
to nathanaelsee/executorch
that referenced
this pull request
May 21, 2024
Summary:
Seeing some ops in graph like:
```aten edge dialect
new_k[-self.left_context :, :, :],
slice_66: "f32[10, 1, 256]" = torch.ops.aten.slice.Tensor(cat_8, 0, -10, 9223372036854775807); cat_8 = None
```
Negative indices and 9223372036854775807 are valid inputs to `start` and `end` params on slice op, but runtime checks in Slice.cpp don't accept them.
(9223372036854775807 is the max value of signed int_64; it maps to the index not being provided.)
Adding code to compute the real values to the range [0, size(dim))
Differential Revision: D57597106
nathanaelsee
force-pushed
the
export-D57597106
branch
from
2cc1bc9 to
7cecd73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57597106 |
jorgep31415
approved these changes
May 22, 2024
nathanaelsee
force-pushed
the
export-D57597106
branch
from
7cecd73 to
8733db7
Compare
nathanaelsee
added a commit
to nathanaelsee/executorch
that referenced
this pull request
May 25, 2024
Summary:
Seeing some ops in graph like:
```aten edge dialect
new_k[-self.left_context :, :, :],
slice_66: "f32[10, 1, 256]" = torch.ops.aten.slice.Tensor(cat_8, 0, -10, 9223372036854775807); cat_8 = None
```
Negative indices and 9223372036854775807 are valid inputs to `start` and `end` params on slice op, but runtime checks in Slice.cpp don't accept them.
(9223372036854775807 is the max value of signed int_64; it maps to the index not being provided.)
Adding code to compute the real values to the range [0, size(dim))
Reviewed By: jorgep31415
Differential Revision: D57597106
Summary:
Seeing some ops in graph like:
```aten edge dialect
new_k[-self.left_context :, :, :],
slice_66: "f32[10, 1, 256]" = torch.ops.aten.slice.Tensor(cat_8, 0, -10, 9223372036854775807); cat_8 = None
```
Negative indices and 9223372036854775807 are valid inputs to `start` and `end` params on slice op, but runtime checks in Slice.cpp don't accept them.
(9223372036854775807 is the max value of signed int_64; it maps to the index not being provided.)
Adding code to compute the real values to the range [0, size(dim))
Reviewed By: jorgep31415
Differential Revision: D57597106
|
This pull request was exported from Phabricator. Differential Revision: D57597106 |
nathanaelsee
force-pushed
the
export-D57597106
branch
from
8733db7 to
080024b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57597106 |
|
This pull request has been merged in b8f92df. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Seeing some ops in graph like:
Negative indices and 9223372036854775807 are valid inputs to
startandendparams on slice op, but runtime checks in Slice.cpp don't accept them.(9223372036854775807 is the max value of signed int_64; it maps to the index not being provided.)
Adding code to compute the real values to the range [0, size(dim))
Differential Revision: D57597106