aten.sin, aten.cos, aten.neg #3706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3706
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57646317 |
jorgep31415
approved these changes
May 23, 2024
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
May 23, 2024
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
May 23, 2024
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
May 23, 2024
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
huiyujie
force-pushed
the
export-D57646317
branch
from
0876706 to
3dd061b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57646317 |
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
May 23, 2024
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
huiyujie
force-pushed
the
export-D57646317
branch
from
3dd061b to
7e02832
Compare
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
|
This pull request was exported from Phabricator. Differential Revision: D57646317 |
huiyujie
force-pushed
the
export-D57646317
branch
from
7e02832 to
62645f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57646317 |
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
May 23, 2024
Summary: Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317
|
This pull request has been merged in 2194486. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
May 24, 2024
Summary: Pull Request resolved: pytorch#3706 Implement 3 unary ops: ``` - func: sin(Tensor self) -> Tensor - func: cos(Tensor self) -> Tensor - func: neg(Tensor self) -> Tensor ``` Relax atol and rtol to make it pass some tests. Need customized configuration of atol and rtol in the future bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: derekxu, jorgep31415 Differential Revision: D57646317 fbshipit-source-id: 3ca45439021684754f10177d62260053dabeb001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement 3 unary ops:
Reviewed By: derekxu, jorgep31415
Differential Revision: D57646317